Add preconditioner to sparse solver #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 99.01% 99.03% +0.01%
==========================================
Files 4 4
Lines 1833 1869 +36
==========================================
+ Hits 1815 1851 +36
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tyler-a-cox
force-pushed
the
precondition_sparse_solver
branch
from
81e2433 to
586a6f5
Compare
for more information, see https://pre-commit.ci
jsdillon
requested changes
Feb 14, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jsdillon
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a preconditioner option to the sparse solver that is helpful for handling cases in which the input weights have large flagging gaps relative to the filter size or the weights are non-binary and frequency/time dependent. Here's comparison of the methods on a simulated case when the flagging mask has large gaps and frequency dependent non-zero weights.